replace_symbolt can now replace tag type symbols #2845
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
peterschrammel,
pkesseli and
smowton
as code owners
|
My understanding (as implemented in #2723) was that we don't need replacement for type symbols (or, for that matter, tags) at all? |
|
Yes, my suspicion is that we simply won't need this eventually. |
|
@kroening Can this be closed? |
kroening
force-pushed
the
replace-symbol-tags
branch
from
6a12505 to
6dd3d3c
Compare
|
Closing as this as long neglected and also since the mentioned PR that may also solve the same issue (#2723) has been merged. Please reopen if you believe this is erroneous or something is missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obvious interaction with #2723.